Przeglądaj źródła

Replace remove with detach where needed

Denis K 8 lat temu
rodzic
commit
7ac74dd259

+ 1 - 1
jet/static/jet/js/src/features/siblings.js

@@ -6,7 +6,7 @@ var Siblings = function($siblings) {
 
 Siblings.prototype = {
     moveSiblings: function($siblings) {
-        $siblings.remove().insertBefore($('.object-tools'));
+        $siblings.detach().insertBefore($('.object-tools'));
     },
     run: function() {
         try {

+ 2 - 4
jet/static/jet/js/src/layout-updaters/actions.js

@@ -24,15 +24,13 @@ ActionsUpdater.prototype = {
                 .wrapAll($wrapper);
     },
     moveActions: function($actions) {
-        $actions.remove();
-
         var $paginator = this.$changelist.find('.paginator');
         var $wrapper = $('<div>').addClass('changelist-footer');
 
         $wrapper.insertAfter($paginator);
 
-        $actions.remove();
-        $paginator.remove();
+        $actions.detach();
+        $paginator.detach();
 
         $wrapper.append($actions);
         $wrapper.append($paginator);

+ 2 - 2
jet/static/jet/js/src/layout-updaters/paginator.js

@@ -43,7 +43,7 @@ PaginatorUpdater.prototype = {
             if (pageNode && !pagesEnded) {
                 var $node = $(this);
 
-                $node.remove();
+                $node.detach();
                 $pageNodes = $pageNodes.add($node);
             } else {
                 pagesEnded = true
@@ -64,7 +64,7 @@ PaginatorUpdater.prototype = {
             } else if (foundPage && !pageNode && this.tagName != 'INPUT') {
                 var $node = $(this);
 
-                $node.remove();
+                $node.detach();
                 $nodes = $nodes.add($node);
             }
         });

+ 1 - 1
jet/static/jet/js/src/layout-updaters/stacked-inline.js

@@ -15,7 +15,7 @@ StackedInlineUpdater.prototype = {
             .text('');
         $changelink
             .text('')
-            .remove()
+            .detach()
             .insertAfter($label);
     },
     run: function() {