test_django.py 9.6 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257
  1. import pytest
  2. from contextlib import contextmanager
  3. from case import Mock, mock, patch
  4. from celery.fixups.django import (
  5. _maybe_close_fd,
  6. fixup,
  7. FixupWarning,
  8. DjangoFixup,
  9. DjangoWorkerFixup,
  10. )
  11. class FixupCase:
  12. Fixup = None
  13. @contextmanager
  14. def fixup_context(self, app):
  15. with patch('celery.fixups.django.DjangoWorkerFixup.validate_models'):
  16. with patch('celery.fixups.django.symbol_by_name') as symbyname:
  17. with patch('celery.fixups.django.import_module') as impmod:
  18. f = self.Fixup(app)
  19. yield f, impmod, symbyname
  20. class test_DjangoFixup(FixupCase):
  21. Fixup = DjangoFixup
  22. def test_setting_default_app(self):
  23. from celery import _state
  24. prev, _state.default_app = _state.default_app, None
  25. try:
  26. app = Mock(name='app')
  27. DjangoFixup(app)
  28. app.set_default.assert_called_with()
  29. finally:
  30. _state.default_app = prev
  31. @patch('celery.fixups.django.DjangoWorkerFixup')
  32. def test_worker_fixup_property(self, DjangoWorkerFixup):
  33. f = DjangoFixup(self.app)
  34. f._worker_fixup = None
  35. assert f.worker_fixup is DjangoWorkerFixup()
  36. assert f.worker_fixup is DjangoWorkerFixup()
  37. def test_on_import_modules(self):
  38. f = DjangoFixup(self.app)
  39. f.worker_fixup = Mock(name='worker_fixup')
  40. f.on_import_modules()
  41. f.worker_fixup.validate_models.assert_called_with()
  42. def test_autodiscover_tasks(self, patching):
  43. patching.modules('django.apps')
  44. from django.apps import apps
  45. f = DjangoFixup(self.app)
  46. configs = [Mock(name='c1'), Mock(name='c2')]
  47. apps.get_app_configs.return_value = configs
  48. assert f.autodiscover_tasks() == [c.name for c in configs]
  49. def test_fixup(self, patching):
  50. with patch('celery.fixups.django.DjangoFixup') as Fixup:
  51. patching.setenv('DJANGO_SETTINGS_MODULE', '')
  52. fixup(self.app)
  53. Fixup.assert_not_called()
  54. patching.setenv('DJANGO_SETTINGS_MODULE', 'settings')
  55. with mock.mask_modules('django'):
  56. with pytest.warns(FixupWarning):
  57. fixup(self.app)
  58. Fixup.assert_not_called()
  59. with mock.module_exists('django'):
  60. fixup(self.app)
  61. Fixup.assert_called()
  62. def test_maybe_close_fd(self):
  63. with patch('os.close'):
  64. _maybe_close_fd(Mock())
  65. _maybe_close_fd(object())
  66. def test_init(self):
  67. with self.fixup_context(self.app) as (f, importmod, sym):
  68. assert f
  69. def test_install(self, patching):
  70. self.app.loader = Mock()
  71. self.cw = patching('os.getcwd')
  72. self.p = patching('sys.path')
  73. self.sigs = patching('celery.fixups.django.signals')
  74. with self.fixup_context(self.app) as (f, _, _):
  75. self.cw.return_value = '/opt/vandelay'
  76. f.install()
  77. self.sigs.worker_init.connect.assert_called_with(f.on_worker_init)
  78. assert self.app.loader.now == f.now
  79. self.p.append.assert_called_with('/opt/vandelay')
  80. def test_now(self):
  81. with self.fixup_context(self.app) as (f, _, _):
  82. assert f.now(utc=True)
  83. f._now.assert_not_called()
  84. assert f.now(utc=False)
  85. f._now.assert_called()
  86. def test_on_worker_init(self):
  87. with self.fixup_context(self.app) as (f, _, _):
  88. with patch('celery.fixups.django.DjangoWorkerFixup') as DWF:
  89. f.on_worker_init()
  90. DWF.assert_called_with(f.app)
  91. DWF.return_value.install.assert_called_with()
  92. assert f._worker_fixup is DWF.return_value
  93. class test_DjangoWorkerFixup(FixupCase):
  94. Fixup = DjangoWorkerFixup
  95. def test_init(self):
  96. with self.fixup_context(self.app) as (f, importmod, sym):
  97. assert f
  98. def test_install(self):
  99. self.app.conf = {'CELERY_DB_REUSE_MAX': None}
  100. self.app.loader = Mock()
  101. with self.fixup_context(self.app) as (f, _, _):
  102. with patch('celery.fixups.django.signals') as sigs:
  103. f.install()
  104. sigs.beat_embedded_init.connect.assert_called_with(
  105. f.close_database,
  106. )
  107. sigs.worker_ready.connect.assert_called_with(f.on_worker_ready)
  108. sigs.task_prerun.connect.assert_called_with(f.on_task_prerun)
  109. sigs.task_postrun.connect.assert_called_with(f.on_task_postrun)
  110. sigs.worker_process_init.connect.assert_called_with(
  111. f.on_worker_process_init,
  112. )
  113. def test_on_worker_process_init(self, patching):
  114. with self.fixup_context(self.app) as (f, _, _):
  115. with patch('celery.fixups.django._maybe_close_fd') as mcf:
  116. _all = f._db.connections.all = Mock()
  117. conns = _all.return_value = [
  118. Mock(), Mock(),
  119. ]
  120. conns[0].connection = None
  121. with patch.object(f, 'close_cache'):
  122. with patch.object(f, '_close_database'):
  123. f.on_worker_process_init()
  124. mcf.assert_called_with(conns[1].connection)
  125. f.close_cache.assert_called_with()
  126. f._close_database.assert_called_with()
  127. f.validate_models = Mock(name='validate_models')
  128. patching.setenv('FORKED_BY_MULTIPROCESSING', '1')
  129. f.on_worker_process_init()
  130. f.validate_models.assert_called_with()
  131. def test_on_task_prerun(self):
  132. task = Mock()
  133. with self.fixup_context(self.app) as (f, _, _):
  134. task.request.is_eager = False
  135. with patch.object(f, 'close_database'):
  136. f.on_task_prerun(task)
  137. f.close_database.assert_called_with()
  138. task.request.is_eager = True
  139. with patch.object(f, 'close_database'):
  140. f.on_task_prerun(task)
  141. f.close_database.assert_not_called()
  142. def test_on_task_postrun(self):
  143. task = Mock()
  144. with self.fixup_context(self.app) as (f, _, _):
  145. with patch.object(f, 'close_cache'):
  146. task.request.is_eager = False
  147. with patch.object(f, 'close_database'):
  148. f.on_task_postrun(task)
  149. f.close_database.assert_called()
  150. f.close_cache.assert_called()
  151. # when a task is eager, don't close connections
  152. with patch.object(f, 'close_cache'):
  153. task.request.is_eager = True
  154. with patch.object(f, 'close_database'):
  155. f.on_task_postrun(task)
  156. f.close_database.assert_not_called()
  157. f.close_cache.assert_not_called()
  158. def test_close_database(self):
  159. with self.fixup_context(self.app) as (f, _, _):
  160. with patch.object(f, '_close_database') as _close:
  161. f.db_reuse_max = None
  162. f.close_database()
  163. _close.assert_called_with()
  164. _close.reset_mock()
  165. f.db_reuse_max = 10
  166. f._db_recycles = 3
  167. f.close_database()
  168. _close.assert_not_called()
  169. assert f._db_recycles == 4
  170. _close.reset_mock()
  171. f._db_recycles = 20
  172. f.close_database()
  173. _close.assert_called_with()
  174. assert f._db_recycles == 1
  175. def test__close_database(self):
  176. with self.fixup_context(self.app) as (f, _, _):
  177. conns = [Mock(), Mock(), Mock()]
  178. conns[1].close.side_effect = KeyError('already closed')
  179. f.DatabaseError = KeyError
  180. f.interface_errors = ()
  181. f._db.connections = Mock() # ConnectionHandler
  182. f._db.connections.all.side_effect = lambda: conns
  183. f._close_database()
  184. conns[0].close.assert_called_with()
  185. conns[1].close.assert_called_with()
  186. conns[2].close.assert_called_with()
  187. conns[1].close.side_effect = KeyError('omg')
  188. with pytest.raises(KeyError):
  189. f._close_database()
  190. def test_close_cache(self):
  191. with self.fixup_context(self.app) as (f, _, _):
  192. f.close_cache()
  193. f._cache.cache.close.assert_called_with()
  194. f._cache.cache.close.side_effect = TypeError()
  195. f.close_cache()
  196. def test_on_worker_ready(self):
  197. with self.fixup_context(self.app) as (f, _, _):
  198. f._settings.DEBUG = False
  199. f.on_worker_ready()
  200. with pytest.warns(UserWarning):
  201. f._settings.DEBUG = True
  202. f.on_worker_ready()
  203. def test_validate_models(self, patching):
  204. with mock.module('django', 'django.db', 'django.core',
  205. 'django.core.cache', 'django.conf',
  206. 'django.db.utils'):
  207. f = self.Fixup(self.app)
  208. f.django_setup = Mock(name='django.setup')
  209. patching.modules('django.core.checks')
  210. from django.core.checks import run_checks
  211. f.validate_models()
  212. f.django_setup.assert_called_with()
  213. run_checks.assert_called_with()
  214. def test_django_setup(self, patching):
  215. patching('celery.fixups.django.symbol_by_name')
  216. patching('celery.fixups.django.import_module')
  217. django, = patching.modules('django')
  218. f = self.Fixup(self.app)
  219. f.django_setup()
  220. django.setup.assert_called_with()