123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884 |
- .. _guide-tasks:
- =====================================================================
- Tasks
- =====================================================================
- Tasks are the building blocks of Celery applications.
- A task is a class that can be created out of any callable. It performs
- dual roles in that it defines both what happens when a task is
- called (sends a message), and what happens when a worker receives that message.
- Every task class has a unique name, and this name is referenced in messages
- so the worker can find the right function to execute.
- A task message is not removed from the queue
- until that message has been :term:`acknowledged` by a worker. A worker can reserve
- many messages in advance and even if the worker is killed -- by power failure
- or some other reason -- the message will be redelivered to another worker.
- Ideally task functions should be :term:`idempotent`: meaning
- the function won't cause unintended effects even if called
- multiple times with the same arguments.
- Since the worker cannot detect if your tasks are idempotent, the default
- behavior is to acknowledge the message in advance, just before it's executed,
- so that a task invocation that already started is never executed again.
- If your task is idempotent you can set the :attr:`~Task.acks_late` option
- to have the worker acknowledge the message *after* the task returns
- instead. See also the FAQ entry :ref:`faq-acks_late-vs-retry`.
- Note that the worker will acknowledge the message if the child process executing
- the task is terminated (either by the task calling :func:`sys.exit`, or by signal)
- even when :attr:`~Task.acks_late` is enabled. This behavior is by purpose
- as...
- #. We don't want to rerun tasks that forces the kernel to send
- a :sig:`SIGSEGV` (segmentation fault) or similar signals to the process.
- #. We assume that a system administrator deliberately killing the task
- does not want it to automatically restart.
- #. A task that allocates too much memory is in danger of triggering the kernel
- OOM killer, the same may happen again.
- #. A task that always fails when redelivered may cause a high-frequency
- message loop taking down the system.
- If you really want a task to be redelivered in these scenarios you should
- consider enabling the :setting:`task_reject_on_worker_lost` setting.
- .. warning::
- A task that blocks indefinitely may eventually stop the worker instance
- from doing any other work.
- If you task does I/O then make sure you add timeouts to these operations,
- like adding a timeout to a web request using the :pypi:`requests` library:
- .. code-block:: python
- connect_timeout, read_timeout = 5.0, 30.0
- response = requests.get(URL, timeout=(connect_timeout, read_timeout))
- :ref:`Time limits <worker-time-limits>` are convenient for making sure all
- tasks return in a timely manner, but a time limit event will actually kill
- the process by force so only use them to detect cases where you haven't
- used manual timeouts yet.
- The default prefork pool scheduler is not friendly to long-running tasks,
- so if you have tasks that run for minutes/hours make sure you enable
- the -Ofair`` command-line argument to the :program:`celery worker`.
- See :ref:`prefork-pool-prefetch` for more information, and for the
- best performance route long-running and short-running tasks to
- dedicated workers (:ref:`routing-automatic`).
- If your worker hangs then please investigate what tasks are running
- before submitting an issue, as most likely the hanging is caused
- by one or more tasks hanging on a network operation.
- --
- In this chapter you'll learn all about defining tasks,
- and this is the **table of contents**:
- .. contents::
- :local:
- :depth: 1
- .. _task-basics:
- Basics
- ======
- You can easily create a task from any callable by using
- the :meth:`~@task` decorator:
- .. code-block:: python
- from .models import User
- @app.task
- def create_user(username, password):
- User.objects.create(username=username, password=password)
- There are also many :ref:`options <task-options>` that can be set for the task,
- these can be specified as arguments to the decorator:
- .. code-block:: python
- @app.task(serializer='json')
- def create_user(username, password):
- User.objects.create(username=username, password=password)
- .. sidebar:: How do I import the task decorator? And what's "app"?
- The task decorator is available on your :class:`@Celery` application instance,
- if you don't know what this is then please read :ref:`first-steps`.
- If you're using Django (see :ref:`django-first-steps`), or you're the author
- of a library then you probably want to use the :func:`@shared_task` decorator:
- .. code-block:: python
- from celery import shared_task
- @shared_task
- def add(x, y):
- return x + y
- .. sidebar:: Multiple decorators
- When using multiple decorators in combination with the task
- decorator you must make sure that the `task`
- decorator is applied last (oddly, in Python this means it must
- be first in the list):
- .. code-block:: python
- @app.task
- @decorator2
- @decorator1
- def add(x, y):
- return x + y
- Bound tasks
- -----------
- A task being bound means the first argument to the task will always
- be the task instance (``self``), just like Python bound methods:
- .. code-block:: python
- logger = get_task_logger(__name__)
- @task(bind=True)
- def add(self, x, y):
- logger.info(self.request.id)
- Bound tasks are needed for retries (using :meth:`Task.retry() <@Task.retry>`),
- for accessing information about the current task request, and for any
- additional functionality you add to custom task base classes.
- Task inheritance
- ----------------
- The ``base`` argument to the task decorator specifies the base class of the task:
- .. code-block:: python
- import celery
- class MyTask(celery.Task):
- def on_failure(self, exc, task_id, args, kwargs, einfo):
- print('{0!r} failed: {1!r}'.format(task_id, exc)
- @task(base=MyTask)
- def add(x, y):
- raise KeyError()
- .. _task-names:
- Names
- =====
- Every task must have a unique name.
- If no explicit name is provided the task decorator will generate one for you,
- and this name will be based on 1) the module the task is defined in, and 2)
- the name of the task function.
- Example setting explicit name:
- .. code-block:: pycon
- >>> @app.task(name='sum-of-two-numbers')
- >>> def add(x, y):
- ... return x + y
- >>> add.name
- 'sum-of-two-numbers'
- A best practice is to use the module name as a name-space,
- this way names won't collide if there's already a task with that name
- defined in another module.
- .. code-block:: pycon
- >>> @app.task(name='tasks.add')
- >>> def add(x, y):
- ... return x + y
- You can tell the name of the task by investigating its ``.name`` attribute:
- .. code-block:: pycon
- >>> add.name
- 'tasks.add'
- The name we specified here (``tasks.add``) is exactly the name that would've
- been automatically generated for us if the task was defined in a module
- named :file:`tasks.py`:
- :file:`tasks.py`:
- .. code-block:: python
- @app.task
- def add(x, y):
- return x + y
- .. code-block:: pycon
- >>> from tasks import add
- >>> add.name
- 'tasks.add'
- .. _task-naming-relative-imports:
- Automatic naming and relative imports
- -------------------------------------
- .. sidebar:: Absolute Imports
- The best practice for developers targetting Python 2 is to add the
- following to the top of **every module**:
- .. code-block:: python
- from __future__ import absolute_import
- This will force you to always use absolute imports so you will
- never have any problems with tasks using relative names.
- Absolute imports are the default in Python 3 so you don't need this
- if you target that version.
- Relative imports and automatic name generation don't go well together,
- so if you're using relative imports you should set the name explicitly.
- For example if the client imports the module ``"myapp.tasks"``
- as ``".tasks"``, and the worker imports the module as ``"myapp.tasks"``,
- the generated names won't match and an :exc:`~@NotRegistered` error will
- be raised by the worker.
- This is also the case when using Django and using ``project.myapp``-style
- naming in ``INSTALLED_APPS``:
- .. code-block:: python
- INSTALLED_APPS = ['project.myapp']
- If you install the app under the name ``project.myapp`` then the
- tasks module will be imported as ``project.myapp.tasks``,
- so you must make sure you always import the tasks using the same name:
- .. code-block:: pycon
- >>> from project.myapp.tasks import mytask # << GOOD
- >>> from myapp.tasks import mytask # << BAD!!!
- The second example will cause the task to be named differently
- since the worker and the client imports the modules under different names:
- .. code-block:: pycon
- >>> from project.myapp.tasks import mytask
- >>> mytask.name
- 'project.myapp.tasks.mytask'
- >>> from myapp.tasks import mytask
- >>> mytask.name
- 'myapp.tasks.mytask'
- For this reason you must be consistent in how you
- import modules, and that is also a Python best practice.
- Similarly, you shouldn't use old-style relative imports:
- .. code-block:: python
- from module import foo # BAD!
- from proj.module import foo # GOOD!
- New-style relative imports are fine and can be used:
- .. code-block:: python
- from .module import foo # GOOD!
- If you want to use Celery with a project already using these patterns
- extensively and you don't have the time to refactor the existing code
- then you can consider specifying the names explicitly instead of relying
- on the automatic naming:
- .. code-block:: python
- @task(name='proj.tasks.add')
- def add(x, y):
- return x + y
- .. _task-name-generator-info:
- Changing the automatic naming behavior
- --------------------------------------
- .. versionadded:: 4.0
- There are some cases when the default automatic naming isn't suitable.
- Consider you have many tasks within many different modules::
- project/
- /__init__.py
- /celery.py
- /moduleA/
- /__init__.py
- /tasks.py
- /moduleB/
- /__init__.py
- /tasks.py
- Using the default automatic naming, each task will have a generated name
- like `moduleA.tasks.taskA`, `moduleA.tasks.taskB`, `moduleB.tasks.test`,
- and so on. You may want to get rid of having `tasks` in all task names.
- As pointed above, you can explicitly give names for all tasks, or you
- can change the automatic naming behavior by overriding
- :meth:`@gen_task_name`. Continuing with the example, `celery.py`
- may contain:
- .. code-block:: python
- from celery import Celery
- class MyCelery(Celery):
- def gen_task_name(self, name, module):
- if module.endswith('.tasks'):
- module = module[:-6]
- return super().gen_task_name(name, module)
- app = MyCelery('main')
- So each task will have a name like `moduleA.taskA`, `moduleA.taskB` and
- `moduleB.test`.
- .. warning::
- Make sure that your :meth:`@gen_task_name` is a pure function: meaning
- that for the same input it must always return the same output.
- .. _task-request-info:
- Task Request
- ============
- :attr:`Task.request <@Task.request>` contains information and state
- related to the currently executing task.
- The request defines the following attributes:
- :id: The unique id of the executing task.
- :group: The unique id of the task's :ref:`group <canvas-group>`, if this task is a member.
- :chord: The unique id of the chord this task belongs to (if the task
- is part of the header).
- :correlation_id: Custom ID used for things like de-duplication.
- :args: Positional arguments.
- :kwargs: Keyword arguments.
- :origin: Name of host that sent this task.
- :retries: How many times the current task has been retried.
- An integer starting at `0`.
- :is_eager: Set to :const:`True` if the task is executed locally in
- the client, not by a worker.
- :eta: The original ETA of the task (if any).
- This is in UTC time (depending on the :setting:`enable_utc`
- setting).
- :expires: The original expiry time of the task (if any).
- This is in UTC time (depending on the :setting:`enable_utc`
- setting).
- :hostname: Node name of the worker instance executing the task.
- :delivery_info: Additional message delivery information. This is a mapping
- containing the exchange and routing key used to deliver this
- task. Used by for example :meth:`Task.retry() <@Task.retry>`
- to resend the task to the same destination queue.
- Availability of keys in this dict depends on the
- message broker used.
- :reply-to: Name of queue to send replies back to (used with RPC result
- backend for example).
- :called_directly: This flag is set to true if the task wasn't
- executed by the worker.
- :timelimit: A tuple of the current ``(soft, hard)`` time limits active for
- this task (if any).
- :callbacks: A list of signatures to be called if this task returns successfully.
- :errback: A list of signatures to be called if this task fails.
- :utc: Set to true the caller has UTC enabled (:setting:`enable_utc`).
- .. versionadded:: 3.1
- :headers: Mapping of message headers sent with this task message
- (may be :const:`None`).
- :reply_to: Where to send reply to (queue name).
- :correlation_id: Usually the same as the task id, often used in amqp
- to keep track of what a reply is for.
- .. versionadded:: 4.0
- :root_id: The unique id of the first task in the workflow this task
- is part of (if any).
- :parent_id: The unique id of the task that called this task (if any).
- :chain: Reversed list of tasks that form a chain (if any).
- The last item in this list will be the next task to succeed the
- current task. If using version one of the task protocol the chain
- tasks will be in ``request.callbacks`` instead.
- Example
- -------
- An example task accessing information in the context is:
- .. code-block:: python
- @app.task(bind=True)
- def dump_context(self, x, y):
- print('Executing task id {0.id}, args: {0.args!r} kwargs: {0.kwargs!r}'.format(
- self.request))
- The ``bind`` argument means that the function will be a "bound method" so
- that you can access attributes and methods on the task type instance.
- .. _task-logging:
- Logging
- =======
- The worker will automatically set up logging for you, or you can
- configure logging manually.
- A special logger is available named "celery.task", you can inherit
- from this logger to automatically get the task name and unique id as part
- of the logs.
- The best practice is to create a common logger
- for all of your tasks at the top of your module:
- .. code-block:: python
- from celery.utils.log import get_task_logger
- logger = get_task_logger(__name__)
- @app.task
- def add(x, y):
- logger.info('Adding {0} + {1}'.format(x, y))
- return x + y
- Celery uses the standard Python logger library,
- and the documentation can be found :mod:`here <logging>`.
- You can also use :func:`print`, as anything written to standard
- out/-err will be redirected to the logging system (you can disable this,
- see :setting:`worker_redirect_stdouts`).
- .. note::
- The worker won't update the redirection if you create a logger instance
- somewhere in your task or task module.
- If you want to redirect ``sys.stdout`` and ``sys.stderr`` to a custom
- logger you have to enable this manually, for example:
- .. code-block:: python
- import sys
- logger = get_task_logger(__name__)
- @app.task(bind=True)
- def add(self, x, y):
- old_outs = sys.stdout, sys.stderr
- rlevel = self.app.conf.worker_redirect_stdouts_level
- try:
- self.app.log.redirect_stdouts_to_logger(logger, rlevel)
- print('Adding {0} + {1}'.format(x, y))
- return x + y
- finally:
- sys.stdout, sys.stderr = old_outs
- .. _task-argument-checking:
- Argument checking
- -----------------
- .. versionadded:: 4.0
- Celery will verify the arguments passed when you call the task, just
- like Python does when calling a normal function:
- .. code-block:: pycon
- >>> @app.task
- ... def add(x, y):
- ... return x + y
- # Calling the task with two arguments works:
- >>> add.delay(8, 8)
- <AsyncResult: f59d71ca-1549-43e0-be41-4e8821a83c0c>
- # Calling the task with only one argument fails:
- >>> add.delay(8)
- Traceback (most recent call last):
- File "<stdin>", line 1, in <module>
- File "celery/app/task.py", line 376, in delay
- return self.apply_async(args, kwargs)
- File "celery/app/task.py", line 485, in apply_async
- check_arguments(*(args or ()), **(kwargs or {}))
- TypeError: add() takes exactly 2 arguments (1 given)
- You can disable the argument checking for any task by setting its
- :attr:`~@Task.typing` attribute to :const:`False`:
- .. code-block:: pycon
- >>> @app.task(typing=False)
- ... def add(x, y):
- ... return x + y
- # Works locally, but the worker reciving the task will raise an error.
- >>> add.delay(8)
- <AsyncResult: f59d71ca-1549-43e0-be41-4e8821a83c0c>
- Hiding sensitive information in arguments
- -----------------------------------------
- .. versionadded:: 4.0
- When using :setting:`task_protocol` 2 or higher (default since 4.0), you can
- override how positional arguments and keyword arguments are represented in logs
- and monitoring events using the ``argsrepr`` and ``kwargsrepr`` calling
- arguments:
- .. code-block:: pycon
- >>> add.apply_async((2, 3), argsrepr='(<secret-x>, <secret-y>)')
- >>> charge.s(account, card='1234 5678 1234 5678').set(
- ... kwargsrepr=repr({'card': '**** **** **** 5678'})
- ... ).delay()
- .. warning::
- Sensitive information will still be accessible to anyone able
- to read your task message from the broker, or otherwise able intercept it.
- For this reason you should probably encrypt your message if it contains
- sensitive information, or in this example with a credit card number
- the actual number could be stored encrypted in a secure store that you retrieve
- and decrypt in the task itself.
- .. _task-retry:
- Retrying
- ========
- :meth:`Task.retry() <@Task.retry>` can be used to re-execute the task,
- for example in the event of recoverable errors.
- When you call ``retry`` it'll send a new message, using the same
- task-id, and it'll take care to make sure the message is delivered
- to the same queue as the originating task.
- When a task is retried this is also recorded as a task state,
- so that you can track the progress of the task using the result
- instance (see :ref:`task-states`).
- Here's an example using ``retry``:
- .. code-block:: python
- @app.task(bind=True)
- def send_twitter_status(self, oauth, tweet):
- try:
- twitter = Twitter(oauth)
- twitter.update_status(tweet)
- except (Twitter.FailWhaleError, Twitter.LoginError) as exc:
- raise self.retry(exc=exc)
- .. note::
- The :meth:`Task.retry() <@Task.retry>` call will raise an exception so any
- code after the retry won't be reached. This is the :exc:`~@Retry`
- exception, it isn't handled as an error but rather as a semi-predicate
- to signify to the worker that the task is to be retried,
- so that it can store the correct state when a result backend is enabled.
- This is normal operation and always happens unless the
- ``throw`` argument to retry is set to :const:`False`.
- The bind argument to the task decorator will give access to ``self`` (the
- task type instance).
- The ``exc`` method is used to pass exception information that's
- used in logs, and when storing task results.
- Both the exception and the traceback will
- be available in the task state (if a result backend is enabled).
- If the task has a ``max_retries`` value the current exception
- will be re-raised if the max number of retries has been exceeded,
- but this won't happen if:
- - An ``exc`` argument wasn't given.
- In this case the :exc:`~@MaxRetriesExceededError`
- exception will be raised.
- - There's no current exception
- If there's no original exception to re-raise the ``exc``
- argument will be used instead, so:
- .. code-block:: python
- self.retry(exc=Twitter.LoginError())
- will raise the ``exc`` argument given.
- .. _task-retry-custom-delay:
- Using a custom retry delay
- --------------------------
- When a task is to be retried, it can wait for a given amount of time
- before doing so, and the default delay is defined by the
- :attr:`~@Task.default_retry_delay`
- attribute. By default this is set to 3 minutes. Note that the
- unit for setting the delay is in seconds (int or float).
- You can also provide the `countdown` argument to :meth:`~@Task.retry` to
- override this default.
- .. code-block:: python
- @app.task(bind=True, default_retry_delay=30 * 60) # retry in 30 minutes.
- def add(self, x, y):
- try:
- something_raising()
- except Exception as exc:
- # overrides the default delay to retry after 1 minute
- raise self.retry(exc=exc, countdown=60)
- .. _task-autoretry:
- Automatic retry for known exceptions
- ------------------------------------
- .. versionadded:: 4.0
- Sometimes you just want to retry a task whenever a particular exception
- is raised.
- Fortunately, you can tell Celery to automatically retry a task using
- `autoretry_for` argument in `~@Celery.task` decorator:
- .. code-block:: python
- from twitter.exceptions import FailWhaleError
- @app.task(autoretry_for=(FailWhaleError,))
- def refresh_timeline(user):
- return twitter.refresh_timeline(user)
- If you want to specify custom arguments for internal `~@Task.retry`
- call, pass `retry_kwargs` argument to `~@Celery.task` decorator:
- .. code-block:: python
- @app.task(autoretry_for=(FailWhaleError,),
- retry_kwargs={'max_retries': 5})
- def refresh_timeline(user):
- return twitter.refresh_timeline(user)
- This is provided as an alternative to manually handling the exceptions,
- and the example above will do the same as wrapping the task body
- in a :keyword:`try` ... :keyword:`except` statement:
- .. code-block:: python
- @app.task
- def refresh_timeline(user):
- try:
- twitter.refresh_timeline(user)
- except FailWhaleError as exc:
- raise div.retry(exc=exc, max_retries=5)
- If you want to automatically retry on any error, simply use:
- .. code-block:: python
- @app.task(autoretry_for=(Exception,))
- def x():
- ...
- .. _task-options:
- List of Options
- ===============
- The task decorator can take a number of options that change the way
- the task behaves, for example you can set the rate limit for a task
- using the :attr:`rate_limit` option.
- Any keyword argument passed to the task decorator will actually be set
- as an attribute of the resulting task class, and this is a list
- of the built-in attributes.
- General
- -------
- .. _task-general-options:
- .. attribute:: Task.name
- The name the task is registered as.
- You can set this name manually, or a name will be
- automatically generated using the module and class name.
- See also :ref:`task-names`.
- .. attribute:: Task.request
- If the task is being executed this will contain information
- about the current request. Thread local storage is used.
- See :ref:`task-request-info`.
- .. attribute:: Task.max_retries
- Only applies if the task calls ``self.retry`` or if the task is decorated
- with the :ref:`autoretry_for <task-autoretry>` argument.
- The maximum number of attempted retries before giving up.
- If the number of retries exceeds this value a :exc:`~@MaxRetriesExceededError`
- exception will be raised.
- .. note::
- You have to call :meth:`~@Task.retry`
- manually, as it won't automatically retry on exception..
- The default is ``3``.
- A value of :const:`None` will disable the retry limit and the
- task will retry forever until it succeeds.
- .. attribute:: Task.throws
- Optional tuple of expected error classes that shouldn't be regarded
- as an actual error.
- Errors in this list will be reported as a failure to the result backend,
- but the worker won't log the event as an error, and no traceback will
- be included.
- Example:
- .. code-block:: python
- @task(throws=(KeyError, HttpNotFound)):
- def get_foo():
- something()
- Error types:
- - Expected errors (in ``Task.throws``)
- Logged with severity ``INFO``, traceback excluded.
- - Unexpected errors
- Logged with severity ``ERROR``, with traceback included.
- .. attribute:: Task.default_retry_delay
- Default time in seconds before a retry of the task
- should be executed. Can be either :class:`int` or :class:`float`.
- Default is a three minute delay.
- .. attribute:: Task.rate_limit
- Set the rate limit for this task type (limits the number of tasks
- that can be run in a given time frame). Tasks will still complete when
- a rate limit is in effect, but it may take some time before it's allowed to
- start.
- If this is :const:`None` no rate limit is in effect.
- If it is an integer or float, it is interpreted as "tasks per second".
- The rate limits can be specified in seconds, minutes or hours
- by appending `"/s"`, `"/m"` or `"/h"` to the value. Tasks will be evenly
- distributed over the specified time frame.
- Example: `"100/m"` (hundred tasks a minute). This will enforce a minimum
- delay of 600ms between starting two tasks on the same worker instance.
- Default is the :setting:`task_default_rate_limit` setting:
- if not specified means rate limiting for tasks is disabled by default.
- Note that this is a *per worker instance* rate limit, and not a global
- rate limit. To enforce a global rate limit (e.g., for an API with a
- maximum number of requests per second), you must restrict to a given
- queue.
- .. attribute:: Task.time_limit
- The hard time limit, in seconds, for this task.
- When not set the workers default is used.
- .. attribute:: Task.soft_time_limit
- The soft time limit for this task.
- When not set the workers default is used.
- .. attribute:: Task.ignore_result
- Don't store task state. Note that this means you can't use
- :class:`~celery.result.AsyncResult` to check if the task is ready,
- or get its return value.
- .. attribute:: Task.store_errors_even_if_ignored
- If :const:`True`, errors will be stored even if the task is configured
- to ignore results.
- .. attribute:: Task.serializer
- A string identifying the default serialization
- method to use. Defaults to the :setting:`task_serializer`
- setting. Can be `pickle`, `json`, `yaml`, or any custom
- serialization methods that have been registered with
- :mod:`kombu.serialization.registry`.
- Please see :ref:`calling-serializers` for more information.
- .. attribute:: Task.compression
- A string identifying the default compression scheme to use.
- Defaults to the :setting:`task_compression` setting.
- Can be `gzip`, or `bzip2`, or any custom compression schemes
- that have been registered with the :mod:`kombu.compression` registry.
- Please see :ref:`calling-compression` for more information.
- .. attribute:: Task.backend
- The result store backend to use for this task. An instance of one of the
- backend classes in `celery.backends`. Defaults to `app.backend`,
- defined by the :setting:`result_backend` setting.
- .. attribute:: Task.acks_late
- If set to :const:`True` messages for this task will be acknowledged
- **after** the task has been executed, not *just before* (the default
- behavior).
- Note: This means the task may be executed multiple times should the worker
- crash in the middle of execution. Make sure your tasks are
- :term:`idempotent`.
- The global default can be overridden by the :setting:`task_acks_late`
- setting.
- .. _task-track-started:
- .. attribute:: Task.track_started
- If :const:`True` the task will report its status as "started"
- when the task is executed by a worker.
- The default value is :const:`False` as the normal behavior is to not
- report that level of granularity. Tasks are either pending, finished,
- or waiting to be retried. Having a "started" status can be useful for
- when there are long running tasks and there's a need to report what
- task is currently running.
- The host name and process id of the worker executing the task
- will be available in the state meta-data (e.g., `result.info['pid']`)
- The global default can be overridden by the
- :setting:`task_track_started` setting.
- .. seealso::
- The API reference for :class:`~@Task`.
- .. _task-states:
- States
- ======
- Celery can keep track of the tasks current state. The state also contains the
- result of a successful task, or the exception and traceback information of a
- failed task.
- There are several *result backends* to choose from, and they all have
- different strengths and weaknesses (see :ref:`task-result-backends`).
- During its lifetime a task will transition through several possible states,
- and each state may have arbitrary meta-data attached to it. When a task
- moves into a new state the previous state is
- forgotten about, but some transitions can be deducted, (e.g., a task now
- in the :state:`FAILED` state, is implied to have been in the
- :state:`STARTED` state at some point).
- There are also sets of states, like the set of
- :state:`FAILURE_STATES`, and the set of :state:`READY_STATES`.
- The client uses the membership of these sets to decide whether
- the exception should be re-raised (:state:`PROPAGATE_STATES`), or whether
- the state can be cached (it can if the task is ready).
- You can also define :ref:`custom-states`.
- .. _task-result-backends:
- Result Backends
- ---------------
- If you want to keep track of tasks or need the return values, then Celery
- must store or send the states somewhere so that they can be retrieved later.
- There are several built-in result backends to choose from: SQLAlchemy/Django ORM,
- Memcached, RabbitMQ/QPid (``rpc``), and Redis -- or you can define your own.
- No backend works well for every use case.
- You should read about the strengths and weaknesses of each backend, and choose
- the most appropriate for your needs.
- .. seealso::
- :ref:`conf-result-backend`
- RPC Result Backend (RabbitMQ/QPid)
- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- The RPC result backend (`rpc://`) is special as it doesn't actually *store*
- the states, but rather sends them as messages. This is an important difference as it
- means that a result *can only be retrieved once*, and *only by the client
- that initiated the task*. Two different processes can't wait for the same result.
- Even with that limitation, it is an excellent choice if you need to receive
- state changes in real-time. Using messaging means the client doesn't have to
- poll for new states.
- The messages are transient (non-persistent) by default, so the results will
- disappear if the broker restarts. You can configure the result backend to send
- persistent messages using the :setting:`result_persistent` setting.
- Database Result Backend
- ~~~~~~~~~~~~~~~~~~~~~~~
- Keeping state in the database can be convenient for many, especially for
- web applications with a database already in place, but it also comes with
- limitations.
- * Polling the database for new states is expensive, and so you should
- increase the polling intervals of operations, such as `result.get()`.
- * Some databases use a default transaction isolation level that
- isn't suitable for polling tables for changes.
- In MySQL the default transaction isolation level is `REPEATABLE-READ`:
- meaning the transaction won't see changes made by other transactions until
- the current transaction is committed.
- Changing that to the `READ-COMMITTED` isolation level is recommended.
- .. _task-builtin-states:
- Built-in States
- ---------------
- .. state:: PENDING
- PENDING
- ~~~~~~~
- Task is waiting for execution or unknown.
- Any task id that's not known is implied to be in the pending state.
- .. state:: STARTED
- STARTED
- ~~~~~~~
- Task has been started.
- Not reported by default, to enable please see :attr:`@Task.track_started`.
- :meta-data: `pid` and `hostname` of the worker process executing
- the task.
- .. state:: SUCCESS
- SUCCESS
- ~~~~~~~
- Task has been successfully executed.
- :meta-data: `result` contains the return value of the task.
- :propagates: Yes
- :ready: Yes
- .. state:: FAILURE
- FAILURE
- ~~~~~~~
- Task execution resulted in failure.
- :meta-data: `result` contains the exception occurred, and `traceback`
- contains the backtrace of the stack at the point when the
- exception was raised.
- :propagates: Yes
- .. state:: RETRY
- RETRY
- ~~~~~
- Task is being retried.
- :meta-data: `result` contains the exception that caused the retry,
- and `traceback` contains the backtrace of the stack at the point
- when the exceptions was raised.
- :propagates: No
- .. state:: REVOKED
- REVOKED
- ~~~~~~~
- Task has been revoked.
- :propagates: Yes
- .. _custom-states:
- Custom states
- -------------
- You can easily define your own states, all you need is a unique name.
- The name of the state is usually an uppercase string. As an example
- you could have a look at the :mod:`abortable tasks <~celery.contrib.abortable>`
- which defines a custom :state:`ABORTED` state.
- Use :meth:`~@Task.update_state` to update a task's state:.
- .. code-block:: python
- @app.task(bind=True)
- def upload_files(self, filenames):
- for i, file in enumerate(filenames):
- if not self.request.called_directly:
- self.update_state(state='PROGRESS',
- meta={'current': i, 'total': len(filenames)})
- Here I created the state `"PROGRESS"`, telling any application
- aware of this state that the task is currently in progress, and also where
- it is in the process by having `current` and `total` counts as part of the
- state meta-data. This can then be used to create progress bars for example.
- .. _pickling_exceptions:
- Creating pickleable exceptions
- ------------------------------
- A rarely known Python fact is that exceptions must conform to some
- simple rules to support being serialized by the pickle module.
- Tasks that raise exceptions that aren't pickleable won't work
- properly when Pickle is used as the serializer.
- To make sure that your exceptions are pickleable the exception
- *MUST* provide the original arguments it was instantiated
- with in its ``.args`` attribute. The simplest way
- to ensure this is to have the exception call ``Exception.__init__``.
- Let's look at some examples that work, and one that doesn't:
- .. code-block:: python
- # OK:
- class HttpError(Exception):
- pass
- # BAD:
- class HttpError(Exception):
- def __init__(self, status_code):
- self.status_code = status_code
- # OK:
- class HttpError(Exception):
- def __init__(self, status_code):
- self.status_code = status_code
- Exception.__init__(self, status_code) # <-- REQUIRED
- So the rule is:
- For any exception that supports custom arguments ``*args``,
- ``Exception.__init__(self, *args)`` must be used.
- There's no special support for *keyword arguments*, so if you
- want to preserve keyword arguments when the exception is unpickled
- you have to pass them as regular args:
- .. code-block:: python
- class HttpError(Exception):
- def __init__(self, status_code, headers=None, body=None):
- self.status_code = status_code
- self.headers = headers
- self.body = body
- super().__init__(status_code, headers, body)
- .. _task-semipredicates:
- Semipredicates
- ==============
- The worker wraps the task in a tracing function that records the final
- state of the task. There are a number of exceptions that can be used to
- signal this function to change how it treats the return of the task.
- .. _task-semipred-ignore:
- Ignore
- ------
- The task may raise :exc:`~@Ignore` to force the worker to ignore the
- task. This means that no state will be recorded for the task, but the
- message is still acknowledged (removed from queue).
- This can be used if you want to implement custom revoke-like
- functionality, or manually store the result of a task.
- Example keeping revoked tasks in a Redis set:
- .. code-block:: python
- from celery.exceptions import Ignore
- @app.task(bind=True)
- def some_task(self):
- if redis.ismember('tasks.revoked', self.request.id):
- raise Ignore()
- Example that stores results manually:
- .. code-block:: python
- from celery import states
- from celery.exceptions import Ignore
- @app.task(bind=True)
- def get_tweets(self, user):
- timeline = twitter.get_timeline(user)
- if not self.request.called_directly:
- self.update_state(state=states.SUCCESS, meta=timeline)
- raise Ignore()
- .. _task-semipred-reject:
- Reject
- ------
- The task may raise :exc:`~@Reject` to reject the task message using
- AMQPs ``basic_reject`` method. This won't have any effect unless
- :attr:`Task.acks_late` is enabled.
- Rejecting a message has the same effect as acking it, but some
- brokers may implement additional functionality that can be used.
- For example RabbitMQ supports the concept of `Dead Letter Exchanges`_
- where a queue can be configured to use a dead letter exchange that rejected
- messages are redelivered to.
- .. _`Dead Letter Exchanges`: http://www.rabbitmq.com/dlx.html
- Reject can also be used to re-queue messages, but please be very careful
- when using this as it can easily result in an infinite message loop.
- Example using reject when a task causes an out of memory condition:
- .. code-block:: python
- import errno
- from celery.exceptions import Reject
- @app.task(bind=True, acks_late=True)
- def render_scene(self, path):
- file = get_file(path)
- try:
- renderer.render_scene(file)
- # if the file is too big to fit in memory
- # we reject it so that it's redelivered to the dead letter exchange
- # and we can manually inspect the situation.
- except MemoryError as exc:
- raise Reject(exc, requeue=False)
- except OSError as exc:
- if exc.errno == errno.ENOMEM:
- raise Reject(exc, requeue=False)
- raise self.retry(exc, countdown=10)
- # For any other error we retry after 10 seconds.
- except Exception as exc:
- raise self.retry(exc, countdown=10)
- Example re-queuing the message:
- .. code-block:: python
- from celery.exceptions import Reject
- @app.task(bind=True, acks_late=True)
- def requeues(self):
- if not self.request.delivery_info['redelivered']:
- raise Reject('no reason', requeue=True)
- print('received two times')
- Consult your broker documentation for more details about the ``basic_reject``
- method.
- .. _task-semipred-retry:
- Retry
- -----
- The :exc:`~@Retry` exception is raised by the ``Task.retry`` method
- to tell the worker that the task is being retried.
- .. _task-custom-classes:
- Custom task classes
- ===================
- All tasks inherit from the :class:`@Task` class.
- The :meth:`~@Task.run` method becomes the task body.
- As an example, the following code,
- .. code-block:: python
- @app.task
- def add(x, y):
- return x + y
- will do roughly this behind the scenes:
- .. code-block:: python
- class _AddTask(app.Task):
- def run(self, x, y):
- return x + y
- add = app.tasks[_AddTask.name]
- Instantiation
- -------------
- A task is **not** instantiated for every request, but is registered
- in the task registry as a global instance.
- This means that the ``__init__`` constructor will only be called
- once per process, and that the task class is semantically closer to an
- Actor.
- If you have a task,
- .. code-block:: python
- from celery import Task
- class NaiveAuthenticateServer(Task):
- def __init__(self):
- self.users = {'george': 'password'}
- def run(self, username, password):
- try:
- return self.users[username] == password
- except KeyError:
- return False
- And you route every request to the same process, then it
- will keep state between requests.
- This can also be useful to cache resources,
- For example, a base Task class that caches a database connection:
- .. code-block:: python
- from celery import Task
- class DatabaseTask(Task):
- _db = None
- @property
- def db(self):
- if self._db is None:
- self._db = Database.connect()
- return self._db
- that can be added to tasks like this:
- .. code-block:: python
- @app.task(base=DatabaseTask)
- def process_rows():
- for row in process_rows.db.table.all():
- process_row(row)
- The ``db`` attribute of the ``process_rows`` task will then
- always stay the same in each process.
- Handlers
- --------
- .. method:: after_return(self, status, retval, task_id, args, kwargs, einfo)
- Handler called after the task returns.
- :param status: Current task state.
- :param retval: Task return value/exception.
- :param task_id: Unique id of the task.
- :param args: Original arguments for the task that returned.
- :param kwargs: Original keyword arguments for the task
- that returned.
- :keyword einfo: :class:`~billiard.einfo.ExceptionInfo`
- instance, containing the traceback (if any).
- The return value of this handler is ignored.
- .. method:: on_failure(self, exc, task_id, args, kwargs, einfo)
- This is run by the worker when the task fails.
- :param exc: The exception raised by the task.
- :param task_id: Unique id of the failed task.
- :param args: Original arguments for the task that failed.
- :param kwargs: Original keyword arguments for the task
- that failed.
- :keyword einfo: :class:`~billiard.einfo.ExceptionInfo`
- instance, containing the traceback.
- The return value of this handler is ignored.
- .. method:: on_retry(self, exc, task_id, args, kwargs, einfo)
- This is run by the worker when the task is to be retried.
- :param exc: The exception sent to :meth:`~@Task.retry`.
- :param task_id: Unique id of the retried task.
- :param args: Original arguments for the retried task.
- :param kwargs: Original keyword arguments for the retried task.
- :keyword einfo: :class:`~billiard.einfo.ExceptionInfo`
- instance, containing the traceback.
- The return value of this handler is ignored.
- .. method:: on_success(self, retval, task_id, args, kwargs)
- Run by the worker if the task executes successfully.
- :param retval: The return value of the task.
- :param task_id: Unique id of the executed task.
- :param args: Original arguments for the executed task.
- :param kwargs: Original keyword arguments for the executed task.
- The return value of this handler is ignored.
- .. _task-how-they-work:
- How it works
- ============
- Here come the technical details. This part isn't something you need to know,
- but you may be interested.
- All defined tasks are listed in a registry. The registry contains
- a list of task names and their task classes. You can investigate this registry
- yourself:
- .. code-block:: pycon
- >>> from proj.celery import app
- >>> app.tasks
- {'celery.chord_unlock':
- <@task: celery.chord_unlock>,
- 'celery.backend_cleanup':
- <@task: celery.backend_cleanup>,
- 'celery.chord':
- <@task: celery.chord>}
- This is the list of tasks built-in to Celery. Note that tasks
- will only be registered when the module they're defined in is imported.
- The default loader imports any modules listed in the
- :setting:`imports` setting.
- The :meth:`@task` decorator is responsible for registering your task
- in the applications task registry.
- When tasks are sent, no actual function code is sent with it, just the name
- of the task to execute. When the worker then receives the message it can look
- up the name in its task registry to find the execution code.
- This means that your workers should always be updated with the same software
- as the client. This is a drawback, but the alternative is a technical
- challenge that's yet to be solved.
- .. _task-best-practices:
- Tips and Best Practices
- =======================
- .. _task-ignore_results:
- Ignore results you don't want
- -----------------------------
- If you don't care about the results of a task, be sure to set the
- :attr:`~@Task.ignore_result` option, as storing results
- wastes time and resources.
- .. code-block:: python
- @app.task(ignore_result=True)
- def mytask():
- something()
- Results can even be disabled globally using the :setting:`task_ignore_result`
- setting.
- More optimization tips
- ----------------------
- You find additional optimization tips in the
- :ref:`Optimizing Guide <guide-optimizing>`.
- .. _task-synchronous-subtasks:
- Avoid launching synchronous subtasks
- ------------------------------------
- Having a task wait for the result of another task is really inefficient,
- and may even cause a deadlock if the worker pool is exhausted.
- Make your design asynchronous instead, for example by using *callbacks*.
- **Bad**:
- .. code-block:: python
- @app.task
- def update_page_info(url):
- page = fetch_page.delay(url).get()
- info = parse_page.delay(url, page).get()
- store_page_info.delay(url, info)
- @app.task
- def fetch_page(url):
- return myhttplib.get(url)
- @app.task
- def parse_page(url, page):
- return myparser.parse_document(page)
- @app.task
- def store_page_info(url, info):
- return PageInfo.objects.create(url, info)
- **Good**:
- .. code-block:: python
- def update_page_info(url):
- # fetch_page -> parse_page -> store_page
- chain = fetch_page.s(url) | parse_page.s() | store_page_info.s(url)
- chain()
- @app.task()
- def fetch_page(url):
- return myhttplib.get(url)
- @app.task()
- def parse_page(page):
- return myparser.parse_document(page)
- @app.task(ignore_result=True)
- def store_page_info(info, url):
- PageInfo.objects.create(url=url, info=info)
- Here I instead created a chain of tasks by linking together
- different :func:`~celery.signature`'s.
- You can read about chains and other powerful constructs
- at :ref:`designing-workflows`.
- .. _task-performance-and-strategies:
- Performance and Strategies
- ==========================
- .. _task-granularity:
- Granularity
- -----------
- The task granularity is the amount of computation needed by each subtask.
- In general it is better to split the problem up into many small tasks rather
- than have a few long running tasks.
- With smaller tasks you can process more tasks in parallel and the tasks
- won't run long enough to block the worker from processing other waiting tasks.
- However, executing a task does have overhead. A message needs to be sent, data
- may not be local, etc. So if the tasks are too fine-grained the
- overhead added probably removes any benefit.
- .. seealso::
- The book `Art of Concurrency`_ has a section dedicated to the topic
- of task granularity [AOC1]_.
- .. _`Art of Concurrency`: http://oreilly.com/catalog/9780596521547
- .. [AOC1] Breshears, Clay. Section 2.2.1, "The Art of Concurrency".
- O'Reilly Media, Inc. May 15, 2009. ISBN-13 978-0-596-52153-0.
- .. _task-data-locality:
- Data locality
- -------------
- The worker processing the task should be as close to the data as
- possible. The best would be to have a copy in memory, the worst would be a
- full transfer from another continent.
- If the data is far away, you could try to run another worker at location, or
- if that's not possible - cache often used data, or preload data you know
- is going to be used.
- The easiest way to share data between workers is to use a distributed cache
- system, like `memcached`_.
- .. seealso::
- The paper `Distributed Computing Economics`_ by Jim Gray is an excellent
- introduction to the topic of data locality.
- .. _`Distributed Computing Economics`:
- http://research.microsoft.com/pubs/70001/tr-2003-24.pdf
- .. _`memcached`: http://memcached.org/
- .. _task-state:
- State
- -----
- Since celery is a distributed system, you can't know which process, or
- on what machine the task will be executed. You can't even know if the task will
- run in a timely manner.
- The ancient async sayings tells us that “asserting the world is the
- responsibility of the task”. What this means is that the world view may
- have changed since the task was requested, so the task is responsible for
- making sure the world is how it should be; If you have a task
- that re-indexes a search engine, and the search engine should only be
- re-indexed at maximum every 5 minutes, then it must be the tasks
- responsibility to assert that, not the callers.
- Another gotcha is Django model objects. They shouldn't be passed on as
- arguments to tasks. It's almost always better to re-fetch the object from
- the database when the task is running instead, as using old data may lead
- to race conditions.
- Imagine the following scenario where you have an article and a task
- that automatically expands some abbreviations in it:
- .. code-block:: python
- class Article(models.Model):
- title = models.CharField()
- body = models.TextField()
- @app.task
- def expand_abbreviations(article):
- article.body.replace('MyCorp', 'My Corporation')
- article.save()
- First, an author creates an article and saves it, then the author
- clicks on a button that initiates the abbreviation task:
- .. code-block:: pycon
- >>> article = Article.objects.get(id=102)
- >>> expand_abbreviations.delay(article)
- Now, the queue is very busy, so the task won't be run for another 2 minutes.
- In the meantime another author makes changes to the article, so
- when the task is finally run, the body of the article is reverted to the old
- version because the task had the old body in its argument.
- Fixing the race condition is easy, just use the article id instead, and
- re-fetch the article in the task body:
- .. code-block:: python
- @app.task
- def expand_abbreviations(article_id):
- article = Article.objects.get(id=article_id)
- article.body.replace('MyCorp', 'My Corporation')
- article.save()
- .. code-block:: pycon
- >>> expand_abbreviations.delay(article_id)
- There might even be performance benefits to this approach, as sending large
- messages may be expensive.
- .. _task-database-transactions:
- Database transactions
- ---------------------
- Let's have a look at another example:
- .. code-block:: python
- from django.db import transaction
- @transaction.commit_on_success
- def create_article(request):
- article = Article.objects.create()
- expand_abbreviations.delay(article.pk)
- This is a Django view creating an article object in the database,
- then passing the primary key to a task. It uses the `commit_on_success`
- decorator, that will commit the transaction when the view returns, or
- roll back if the view raises an exception.
- There's a race condition if the task starts executing
- before the transaction has been committed; The database object doesn't exist
- yet!
- The solution is to *always commit transactions before sending tasks
- depending on state from the current transaction*:
- .. code-block:: python
- @transaction.commit_manually
- def create_article(request):
- try:
- article = Article.objects.create()
- except:
- transaction.rollback()
- raise
- else:
- transaction.commit()
- expand_abbreviations.delay(article.pk)
- .. note::
- Django 1.6 (and later) now enables autocommit mode by default,
- and ``commit_on_success``/``commit_manually`` are deprecated.
- This means each SQL query is wrapped and executed in individual
- transactions, making it less likely to experience the
- problem described above.
- However, enabling ``ATOMIC_REQUESTS`` on the database
- connection will bring back the transaction-per-request model and the
- race condition along with it. In this case, the simple solution is
- using the ``@transaction.non_atomic_requests`` decorator to go back
- to autocommit for that view only.
- .. _task-example:
- Example
- =======
- Let's take a real world example: a blog where comments posted need to be
- filtered for spam. When the comment is created, the spam filter runs in the
- background, so the user doesn't have to wait for it to finish.
- I have a Django blog application allowing comments
- on blog posts. I'll describe parts of the models/views and tasks for this
- application.
- ``blog/models.py``
- ------------------
- The comment model looks like this:
- .. code-block:: python
- from django.db import models
- from django.utils.translation import ugettext_lazy as _
- class Comment(models.Model):
- name = models.CharField(_('name'), max_length=64)
- email_address = models.EmailField(_('email address'))
- homepage = models.URLField(_('home page'),
- blank=True, verify_exists=False)
- comment = models.TextField(_('comment'))
- pub_date = models.DateTimeField(_('Published date'),
- editable=False, auto_add_now=True)
- is_spam = models.BooleanField(_('spam?'),
- default=False, editable=False)
- class Meta:
- verbose_name = _('comment')
- verbose_name_plural = _('comments')
- In the view where the comment is posted, I first write the comment
- to the database, then I launch the spam filter task in the background.
- .. _task-example-blog-views:
- ``blog/views.py``
- -----------------
- .. code-block:: python
- from django import forms
- from django.http import HttpResponseRedirect
- from django.template.context import RequestContext
- from django.shortcuts import get_object_or_404, render_to_response
- from blog import tasks
- from blog.models import Comment
- class CommentForm(forms.ModelForm):
- class Meta:
- model = Comment
- def add_comment(request, slug, template_name='comments/create.html'):
- post = get_object_or_404(Entry, slug=slug)
- remote_addr = request.META.get('REMOTE_ADDR')
- if request.method == 'post':
- form = CommentForm(request.POST, request.FILES)
- if form.is_valid():
- comment = form.save()
- # Check spam asynchronously.
- tasks.spam_filter.delay(comment_id=comment.id,
- remote_addr=remote_addr)
- return HttpResponseRedirect(post.get_absolute_url())
- else:
- form = CommentForm()
- context = RequestContext(request, {'form': form})
- return render_to_response(template_name, context_instance=context)
- To filter spam in comments I use `Akismet`_, the service
- used to filter spam in comments posted to the free blog platform
- `Wordpress`. `Akismet`_ is free for personal use, but for commercial use you
- need to pay. You have to sign up to their service to get an API key.
- To make API calls to `Akismet`_ I use the `akismet.py`_ library written by
- `Michael Foord`_.
- .. _task-example-blog-tasks:
- ``blog/tasks.py``
- -----------------
- .. code-block:: python
- from celery import Celery
- from akismet import Akismet
- from django.core.exceptions import ImproperlyConfigured
- from django.contrib.sites.models import Site
- from blog.models import Comment
- app = Celery(broker='amqp://')
- @app.task
- def spam_filter(comment_id, remote_addr=None):
- logger = spam_filter.get_logger()
- logger.info('Running spam filter for comment %s', comment_id)
- comment = Comment.objects.get(pk=comment_id)
- current_domain = Site.objects.get_current().domain
- akismet = Akismet(settings.AKISMET_KEY, 'http://{0}'.format(domain))
- if not akismet.verify_key():
- raise ImproperlyConfigured('Invalid AKISMET_KEY')
- is_spam = akismet.comment_check(user_ip=remote_addr,
- comment_content=comment.comment,
- comment_author=comment.name,
- comment_author_email=comment.email_address)
- if is_spam:
- comment.is_spam = True
- comment.save()
- return is_spam
- .. _`Akismet`: http://akismet.com/faq/
- .. _`akismet.py`: http://www.voidspace.org.uk/downloads/akismet.py
- .. _`Michael Foord`: http://www.voidspace.org.uk/
|