Browse Source

new flakes in flake8 2

Ask Solem 12 years ago
parent
commit
7433565909

+ 0 - 4
celery/app/base.py

@@ -18,10 +18,6 @@ from contextlib import contextmanager
 from copy import deepcopy
 from functools import wraps
 
-try:
-    from billiard import forking as _forking
-except ImportError:  # pragma: no cover
-    _forking = None  # noqa
 from billiard.util import register_after_fork
 from kombu.clocks import LamportClock
 from kombu.utils import cached_property

+ 3 - 3
celery/app/builtins.py

@@ -171,11 +171,11 @@ def add_group_task(app):
             if self.request.is_eager or app.conf.CELERY_ALWAYS_EAGER:
                 return app.GroupResult(
                     result.id,
-                    [task.apply(group_id=group_id) for task in taskit],
+                    [stask.apply(group_id=group_id) for stask in taskit],
                 )
             with app.producer_or_acquire() as pub:
-                [task.apply_async(group_id=group_id, publisher=pub,
-                                  add_to_parent=False) for task in taskit]
+                [stask.apply_async(group_id=group_id, publisher=pub,
+                                   add_to_parent=False) for stask in taskit]
             parent = get_current_worker_task()
             if parent:
                 parent.request.children.append(result)

+ 1 - 1
celery/bin/base.py

@@ -231,7 +231,7 @@ class Command(object):
             options = dict((k, self.expanduser(v))
                            for k, v in vars(options).iteritems()
                            if not k.startswith('_'))
-        args = [self.expanduser(v) for v in args]
+        args = [self.expanduser(arg) for arg in args]
         self.check_args(args)
         return options, args
 

+ 1 - 1
celery/result.py

@@ -726,7 +726,7 @@ def from_serializable(r, app=None):
         if isinstance(r, (list, tuple)):
             id, nodes = r
             if nodes:
-                return app.GroupResult(id, [Result(id) for id, _ in nodes])
+                return app.GroupResult(id, [Result(sid) for sid, _ in nodes])
             return Result(id)
         else:
             return Result(r)

+ 1 - 1
celery/tests/backends/test_base.py

@@ -176,7 +176,7 @@ class KVBackend(KeyValueStoreBackend):
         if self.mget_returns_dict:
             return dict((key, self.get(key)) for key in keys)
         else:
-            return [self.get(key) for key in keys]
+            return [self.get(k) for k in keys]
 
     def delete(self, key):
         self.db.pop(key, None)

+ 1 - 1
celery/tests/tasks/test_chord.py

@@ -157,7 +157,7 @@ class test_Chord_task(AppCase):
 
             body = dict()
             Chord(TaskSet(add.subtask((i, i)) for i in xrange(5)), body)
-            Chord([add.subtask((i, i)) for i in xrange(5)], body)
+            Chord([add.subtask((j, j)) for j in xrange(5)], body)
             self.assertEqual(current_app.backend.on_chord_apply.call_count, 2)
         finally:
             current_app.backend = prev