Browse Source

100% coverage for celery.utils.mail

Ask Solem 11 years ago
parent
commit
5a9d77f56e
2 changed files with 14 additions and 0 deletions
  1. 8 0
      celery/tests/app/test_app.py
  2. 6 0
      celery/tests/utilities/test_mail.py

+ 8 - 0
celery/tests/app/test_app.py

@@ -609,6 +609,14 @@ class test_App(Case):
                                  'hostname': 'lana'}
         self.assertTrue(x)
 
+    def test_error_mail_disabled(self):
+        task = Mock()
+        x = ErrorMail(task)
+        x.should_send = Mock()
+        x.should_send.return_value = False
+        x.send(Mock(), Mock())
+        self.assertFalse(task.app.mail_admins.called)
+
 
 class test_defaults(Case):
 

+ 6 - 0
celery/tests/utilities/test_mail.py

@@ -1,5 +1,7 @@
 from __future__ import absolute_import
 
+import socket
+
 from mock import Mock, patch
 
 from celery.utils.mail import Message, Mailer
@@ -49,3 +51,7 @@ class test_Mailer(Case):
         mailer._send(msg)
 
         client.sendmail.assert_called_With(msg.sender, msg.to, str(msg))
+
+        client.quit.side_effect = socket.sslerror()
+        mailer._send(msg)
+        client.close.assert_called_with()