pyflakes

celery/bin/base.py

@@ -4,7 +4,6 @@ import sys
 from optparse import OptionParser, make_option as Option
 
 import celery
-from celery.utils import import_from_cwd
 
 
 class Command(object):

celery/bin/celeryev.py

@@ -1,5 +1,4 @@
 import sys
-import platform
 
 from celery import platforms
 from celery.bin.base import Command, Option

celery/concurrency/processes/pool.py

@@ -558,7 +558,6 @@ class Pool(object):
         raise
 
     def _worker_active(self, worker):
-        jobs = []
         for job in self._cache.values():
             if worker.pid in job.worker_pids():
                 return True

celery/task/control.py

@@ -1,7 +1,6 @@
 from kombu.pidbox import Mailbox
 
 from celery.app import app_or_default
-from celery.utils import gen_unique_id
 
 
 def flatten_reply(reply):

celery/tests/test_utils.py

@@ -1,13 +1,11 @@
 import pickle
 import sys
-import socket
 import unittest2 as unittest
 
 from celery import utils
 from celery.utils import promise, mpromise, maybe_promise
 
-from celery.tests.utils import sleepdeprived, execute_context
-from celery.tests.utils import mask_modules
+from celery.tests.utils import execute_context, mask_modules
 
 
 def double(x):

celery/tests/test_worker.py

@@ -16,7 +16,6 @@ from celery.utils import gen_unique_id
 from celery.worker import WorkController
 from celery.worker.buckets import FastQueue
 from celery.worker.job import TaskRequest
-from celery.worker import consumer
 from celery.worker.consumer import Consumer as MainConsumer
 from celery.worker.consumer import QoS, RUN
 
@@ -266,6 +265,7 @@ class test_Consumer(unittest.TestCase):
         l.event_dispatcher = MockEventDispatcher()
         l.pidbox_node = MockNode()
 
+        from celery.worker import consumer
         prev, consumer.to_timestamp = consumer.to_timestamp, to_timestamp
         try:
             l.receive_message(m.decode(), m)

celery/utils/__init__.py

@@ -2,7 +2,6 @@ from __future__ import generators
 
 import os
 import sys
-import time
 import operator
 import importlib
 import logging

celery/worker/consumer.py

@@ -293,8 +293,8 @@ class Consumer(object):
     def on_control(self, message, message_data):
         try:
             self.pidbox_node.handle_message(message, message_data)
-        except KeyError:
-            self.logger.error("No such control command: %s" % command)
+        except KeyError, exc:
+            self.logger.error("No such control command: %s" % exc)
 
     def apply_eta_task(self, task):
         state.task_reserved(task)

celery/worker/control/__init__.py

@@ -1,4 +1,6 @@
-from celery.worker.control.registry import Panel
+from celery.worker.control import registry
+
+Panel = registry.Panel
 
 # Loads the built-in remote control commands
 __import__("celery.worker.control.builtins")

celery/worker/control/registry.py

@@ -1,7 +1,5 @@
 from UserDict import UserDict
 
-from celery.app import app_or_default
-
 
 class Panel(UserDict):
     data = dict()                               # Global registry.

celery/worker/controllers.py

@@ -25,7 +25,7 @@ class Autoscaler(threading.Thread):
         self.max_concurrency = max_concurrency
         self.min_concurrency = min_concurrency
         self.keepalive = keepalive
-        self.logger = logger or log.get_default_logger()
+        self.logger = logger
         self._last_action = None
         self._shutdown = threading.Event()
         self._stopped = threading.Event()
@@ -56,7 +56,6 @@ class Autoscaler(threading.Thread):
             try:
                 self.pool.shrink(n)
             except Exception, exc:
-                import traceback
                 traceback.print_stack()
                 self.logger.error("Autoscaler: scale_down: %r" % (exc, ))
 

contrib/release/flakesignore.txt

@@ -29,4 +29,5 @@ celery/utils/functional.py:(.+?) redefinition of unused 'partial'
 celery/utils/functional.py:(.+?) redefinition of unused 'update_wrapper'
 celery/utils/functional.py:(.+?) redefinition of unused 'wraps'
 celery/utils/mail.py:(.+?) redefinition of unused 'MIMEText'
+celery/utils/__init__.py:(.+?) 'gen_unique_id' imported but unused